Add 'wait' option to bindCollection #336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 99.73% 97.94% -1.79%
==========================================
Files 14 14
Lines 371 390 +19
Branches 64 77 +13
==========================================
+ Hits 370 382 +12
- Misses 1 8 +7
Continue to review full report at Codecov.
|
|
@scottgearyau could you fix the codecov/tests? |
|
Thanks for the initiative and the work @scottgearyau ! Unfortunately, I had quite some things going on on the branch that I needed to refactor and it involved quite some extra work so I created #361 instead so the documentation is visible and I should publish a release under a different tag for people interested in the feature to test it. If you are up to testing it, that would be really helpful! You can also review the PR |
| add: (target, newIndex, data) => | ||
| commit(VUEXFIRE_ARRAY_ADD, { target, newIndex, data }, commitOptions), | ||
| add: (target, newIndex, data) => { | ||
| if ('__ob__' in target) { |
There was a problem hiding this comment.
what was the reason behind this? Not using commit would prevent devtools to see it
This commit addresses some issues mentioned in topic #83.
This is by no means tried and tested, but thought I'd give it a start... will create a local array rather than a reference to the reactive prop, and only use .set() when populated.